Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase default timout on RunClientServer methods #55798

Merged
merged 1 commit into from
Jul 16, 2021
Merged

increase default timout on RunClientServer methods #55798

merged 1 commit into from
Jul 16, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 16, 2021

I've seen some timeouts while running parallel sets. Increasing the timeout improved my stability greatly. I no longer see
random timeouts.

@wfurt wfurt requested a review from a team July 16, 2021 04:51
@wfurt wfurt self-assigned this Jul 16, 2021
@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I've seen some timeouts while running parallel sets. Increasing the timeout improved my stability greatly. I no longer see
random timeouts.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic
Milestone: -

@ManickaP
Copy link
Member

@CarnaViire would this help the time-out your seeing in your PR? Maybe it's worth checking out instead of tedious investigations.

@ManickaP
Copy link
Member

ManickaP commented Jul 16, 2021 •
edited
Loading

Also it might fix #55774
EDIT: no it didn't, it has its own timeout.

stephentoub
stephentoub approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just have a general rule in in our tests: for timing out things we expect to succeed and a timeout indicates the test should fail, we shouldn't ever use timeouts less than at least 30s. :)

@stephentoub stephentoub merged commit 145e588 into dotnet:main Jul 16, 2021
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wfurt @ManickaP @stephentoub @karelz